Fix maximum y-value-range computation
ClosedPublic

Authored by alexde on Sep 17 2019, 4:48 PM.

Details

Summary

Rounding to the next 10 did not work if the maximum value was something like y_max = 30.947
In this case modulo 10 gives 0 and therefore the maximum values becomes 30 in the end, though it should be 40
otherwise the peak points outside of the chart.

Floor(max) + 10 always works.

Test Plan

Before:


After:

Diff Detail

Repository
R102 KInfoCenter
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
alexde created this revision.Sep 17 2019, 4:48 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 17 2019, 4:48 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
alexde requested review of this revision.Sep 17 2019, 4:48 PM
alexde edited the test plan for this revision. (Show Details)Sep 17 2019, 4:49 PM
ngraham accepted this revision.Sep 17 2019, 4:51 PM
This revision is now accepted and ready to land.Sep 17 2019, 4:51 PM
This revision was automatically updated to reflect the committed changes.