src/a2dp-codecs.h
33	Are you sure about this?
src/mediatransport.h
47	`quint16`
src/tpendingcall.h
45	Is this really needed? In the end, it doesn't really make the code that much better: TPendingCall<QDBusUnixFileDescriptor, uint16_t, uint16_t> fd = transport->tryAcquire(); fd->valueAt<0>(); fd->valueAt<1>(); fd->valueAt<2>(); vs PendingCall fd = transport->tryAcquire(); fd->values().at(0).value<QDBusUnixFileDescriptor>(); fd->values().at(1).value<uint16_t>(); fd->values().at(2).value<uint16_t>(); Or we can add convenience method `T valueAt(int)` so it becomes: PendingCall *fd = transport->tryAcquire(); fd->valueAt<QDBusUnixFileDescriptor>(0); fd->valueAt<uint16_t>(1); fd->valueAt<uint16_t>(2);

This revision now requires changes to proceed.Jun 27 2019, 5:45 AM

mweichselbaumer added inline comments.

src/a2dp-codecs.h
33	Yes, this has also been fixed by bluez as of 2018-12-28.
src/tpendingcall.h
45	Actually, my intention was to provide a type-safe way to obtain return values from PendingCall and to express explicitly, what the corresponding method returns in API header. As a client you can make use of "auto". Consider: auto *fd = transport->tryAcquire(); // Method declaration will define return type. auto ret1 = fd->valueAt<0>(); auto ret2 = fd->valueAt<1>(); auto ret3 = fd->valueAt<2>(); Thus, return type (of PendingCall) is expressed in API header and clients do not need to express the return types themselves.

ltoscano added inline comments.

src/a2dp-codecs.h
33	Will it work with older versions of bluez?

src/a2dp-codecs.h
33	Bluez just defines this constant, but does not use it internally (nor we do). So, yes, this works with any version of bluez.

drosca added inline comments.

src/tpendingcall.h
45	Alright, that makes sense. With KF6 we can convert all PendingCalls to this form. It would be a good idea to add `TODO: KF6` somewhere to not forget it.

This revision is now accepted and ready to land.Jun 28 2019, 8:29 AM

src/tpendingcall.h
45	Ok, i will update this patch and land it in a couple of days.

Revision Contents
Changeset List

		Path
M		autotests/CMakeLists.txt (2 lines)
M		autotests/autotests.cpp (2 lines)
M		autotests/fakebluez/CMakeLists.txt (1 line)
M		autotests/fakebluez/deviceinterface.h (8 lines)
M		autotests/fakebluez/deviceinterface.cpp (46 lines)
M		autotests/fakebluez/devicemanager.cpp (1 line)
A	M	autotests/fakebluez/mediatransportinterface.h (56 lines)
A	M	autotests/fakebluez/mediatransportinterface.cpp (73 lines)
A	M	autotests/interfaces/org.bluez.MediaTransport1.xml (21 lines)
A	M	autotests/mediatransporttest.h (63 lines)
A	M	autotests/mediatransporttest.cpp (271 lines)
M		src/CMakeLists.txt (2 lines)
M		src/a2dp-codecs.h (2 lines)
M		src/device.h (16 lines)
M		src/device.cpp (5 lines)
M		src/device_p.h (1 line)
M		src/device_p.cpp (11 lines)
A	M	src/mediatransport.h (142 lines)
A	M	src/mediatransport.cpp (70 lines)
A	M	src/mediatransport_p.h (56 lines)
A	M	src/mediatransport_p.cpp (157 lines)
A	M	src/mediatypes.h (66 lines)
M		src/pendingcall.h (9 lines)
M		src/pendingcall.cpp (14 lines)
A	M	src/tpendingcall.h (100 lines)
M		src/types.h (2 lines)
M		src/utils.h (1 line)
M		src/utils.cpp (7 lines)
M		tests/mediaendpointconnector.h (1 line)
M		tests/mediaendpointconnector.cpp (33 lines)

Commit	Tree	Parents	Author	Summary	Date
91f14a9957b2	985f7f8601e9	e3b9698511d3	Manuel Weichselbaumer	Add mediatransporttest	Jun 26 2019, 6:51 PM
e3b9698511d3	c16c543c1e64	3333dee99674	Manuel Weichselbaumer	Add MediaTransport API	Jun 11 2019, 6:06 AM