Differential D21543

Fix narrowing conversion in LineAnnotationWidget::endStyleIcon
ClosedPublic
Actions

Authored by tobiasdeiminger on Jun 2 2019, 11:46 AM.

Details

Reviewers
aacid
Commits
R223:d084641c2de3: Fix narrowing conversion in LineAnnotationWidget::endStyleIcon
Summary

Windows MSVC Qt5.11 build fails:

conversion from 'initializer list' to 'QSizeF' requires a narrowing conversion

Pass QSize, and let QSizeF Ctor QSizeF(const QSize &) do the conversion.

Test Plan
  • build on Windows MSVC

Diff Detail

Repository
R223 Okular
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Okular. · View Herald TranscriptJun 2 2019, 11:46 AM
Restricted Application added a subscriber: okular-devel. · View Herald Transcript
tobiasdeiminger requested review of this revision.Jun 2 2019, 11:46 AM
aacid accepted this revision.Jun 2 2019, 8:05 PM
aacid added a subscriber: aacid.

just commit and try it

This revision is now accepted and ready to land.Jun 2 2019, 8:05 PM
Closed by commit R223:d084641c2de3: Fix narrowing conversion in LineAnnotationWidget::endStyleIcon (authored by tobiasdeiminger). · Explain WhyJun 2 2019, 8:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mui/annotationwidgets.cpp (3 lines)

Diff 59033

View Options

ui/annotationwidgets.cpp

Loading...