Add Bluez API to DBus XML parser/generator
ClosedPublic
Actions

Authored by mweichselbaumer on May 17 2019, 10:24 PM.

Details

Reviewers

Commits

R269:bfe94dface00: Add Bluez API to DBus XML parser/generator

Summary

I created this tool in the hope it is helpful for others.
It generates DBus introspection XMLs out of the original Bluez DBUS api descriptions found at: https://git.kernel.org/pub/scm/bluetooth/bluez.git/tree/doc .
Further plans are to also add a C++ generator.

Please have a look and share your thoughts. Thanks.

Diff Detail

Repository

R269 BluezQt

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

mweichselbaumer requested review of this revision.May 17 2019, 10:24 PM

mweichselbaumer created this revision.

Please use KDE coding style - https://community.kde.org/Policies/Kdelibs_Coding_Style

tools/bluezapi2qt/CMakeLists.txt
2	Why this? You should use QLatin1String/QStringLiteral where appropriate.

This revision now requires changes to proceed.May 20 2019, 12:47 PM

mweichselbaumer added inline comments.May 25 2019, 10:02 AM

tools/bluezapi2qt/CMakeLists.txt
2	Initially, i used QStringLiteral. However, this is really painful, especially when writing a parser/generator using QString/QRegExp. This was more or less a test, whether we could allow this within supplementary tools?

drosca added inline comments.May 28 2019, 2:12 PM

tools/bluezapi2qt/CMakeLists.txt
2	No, you should make it compilable without removing those defines.

Using QStringLiteral and fixed style issues.
Also added C++ adaptor generator

Using QStringLiteral and fixed style issues.
Also added C++ adaptor generator.

How different is the C++ generator from qdbusxml2cpp?

Well, it can directly generate c++ code without going via XML files. Currently, it only generates adaptor code, but could be extended to generate all other c++ related files.
This is just a start.

drosca accepted this revision.May 31 2019, 10:15 AM

This revision is now accepted and ready to land.May 31 2019, 10:15 AM

Closed by commit R269:bfe94dface00: Add Bluez API to DBus XML parser/generator (authored by mweichselbaumer). · Explain WhyMay 31 2019, 5:30 PM

This revision was automatically updated to reflect the committed changes.

Restricted Application added a project: Frameworks. · View Herald TranscriptMay 31 2019, 5:30 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

Revision Contents
Changeset List

		Path
M		CMakeLists.txt (1 line)
A	M	tools/bluezapi2qt/BluezApiParser.h (45 lines)
A	M	tools/bluezapi2qt/BluezApiParser.cpp (68 lines)
A	M	tools/bluezapi2qt/CMakeLists.txt (18 lines)
A	M	tools/bluezapi2qt/Comment.h (36 lines)
A	M	tools/bluezapi2qt/Comment.cpp (52 lines)
A	M	tools/bluezapi2qt/CppGenerator.h (65 lines)
A	M	tools/bluezapi2qt/CppGenerator.cpp (256 lines)
A	M	tools/bluezapi2qt/Interface.h (69 lines)
A	M	tools/bluezapi2qt/Interface.cpp (147 lines)
A	M	tools/bluezapi2qt/Method.h (68 lines)
A	M	tools/bluezapi2qt/Method.cpp (111 lines)
A	M	tools/bluezapi2qt/Methods.h (45 lines)
A	M	tools/bluezapi2qt/Methods.cpp (91 lines)
A	M	tools/bluezapi2qt/Parameter.h (38 lines)
A	M	tools/bluezapi2qt/Parameter.cpp (47 lines)
A	M	tools/bluezapi2qt/Properties.h (43 lines)
A	M	tools/bluezapi2qt/Properties.cpp (77 lines)
A	M	tools/bluezapi2qt/Property.h (57 lines)
A	M	tools/bluezapi2qt/Property.cpp (63 lines)
A	M	tools/bluezapi2qt/TODO (2 lines)
A	M	tools/bluezapi2qt/TypeAnnotation.h (37 lines)
A	M	tools/bluezapi2qt/TypeAnnotation.cpp (71 lines)
A	M	tools/bluezapi2qt/XmlGenerator.h (57 lines)
A	M	tools/bluezapi2qt/XmlGenerator.cpp (155 lines)
A	M	tools/bluezapi2qt/main.cpp (128 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	58229			May 17 2019, 10:22 PM	★	★
Diff 2	58867			May 29 2019, 9:10 PM	★	★
Diff 3	58963	0f6e5e4	R269:bfe94dface0005f0360085539ccb86f5f161de8a	May 31 2019, 5:30 PM	★	★

Add Bluez API to DBus XML parser/generatorClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 58963

CMakeLists.txt

tools/bluezapi2qt/BluezApiParser.h

tools/bluezapi2qt/BluezApiParser.cpp

tools/bluezapi2qt/CMakeLists.txt

tools/bluezapi2qt/Comment.h

tools/bluezapi2qt/Comment.cpp

tools/bluezapi2qt/CppGenerator.h

tools/bluezapi2qt/CppGenerator.cpp

tools/bluezapi2qt/Interface.h

tools/bluezapi2qt/Interface.cpp

tools/bluezapi2qt/Method.h

tools/bluezapi2qt/Method.cpp

tools/bluezapi2qt/Methods.h

tools/bluezapi2qt/Methods.cpp

tools/bluezapi2qt/Parameter.h

tools/bluezapi2qt/Parameter.cpp

tools/bluezapi2qt/Properties.h

tools/bluezapi2qt/Properties.cpp

tools/bluezapi2qt/Property.h

tools/bluezapi2qt/Property.cpp

tools/bluezapi2qt/TODO

tools/bluezapi2qt/TypeAnnotation.h

tools/bluezapi2qt/TypeAnnotation.cpp

tools/bluezapi2qt/XmlGenerator.h

tools/bluezapi2qt/XmlGenerator.cpp

tools/bluezapi2qt/main.cpp

Add Bluez API to DBus XML parser/generator
ClosedPublic
Actions

Revision Contents
Changeset List