Get rid of QMetaObject::invokeMethod() with 'const char *member' arg
AbandonedPublic
Actions

Authored by volkov on Oct 10 2018, 3:58 PM.

Details

Reviewers

rkflx
ngraham

Group Reviewers

Gwenview

Summary

It prevents compile-time checking, use QTimer::singleShot(0, ...)
instead.

Diff Detail

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 3798
Build 3816: arc lint + arc unit

volkov created this revision.Oct 10 2018, 3:58 PM

Restricted Application added a project: Gwenview. · View Herald TranscriptOct 10 2018, 3:58 PM

volkov requested review of this revision.Oct 10 2018, 3:58 PM

Harbormaster completed remote builds in B3729: Diff 43322.Oct 10 2018, 3:58 PM

volkov added a reviewer: Gwenview.Oct 10 2018, 3:59 PM

shubham added reviewers: rkflx, ngraham.Oct 10 2018, 4:00 PM

QMetaObject::invokeMethod takes function pointers since Qt 5.10

Yes, but gwenview requires at least 5.9.
And code is longer with QMetaObject::invokeMethod, compare:
QTimer::singleShot(0, this, &FileOpsContextManagerItem::updateActions);
and
QMetaObject::invokeMethod(this, &FileOpsContextManagerItem::updateActions, Qt::QueuedConnection);

simplify, leave only invokeMethod() -> QTimer::singleShot() change

Harbormaster completed remote builds in B3798: Diff 43467.Oct 12 2018, 2:55 PM

volkov edited the summary of this revision. (Show Details)Oct 12 2018, 2:56 PM

ping

Honestly i'd prefer if we wait for 5.10 and then use QMetaObject::invokeMethod instead of QTimer::singleShot.

AFAIR they're not exactly the same, even if they are 99% similar, so in trying to make we don't break stuff just to have nicer code i'd delay this until we decide to depend on 5.10 for gwenview.

Which IMHO we could right now, but OTOH Ubuntu LTS (that is used by quite some people) has Qt 5.9 so maybe it's not the best of the ideas to break "buildability" in a "popular" distro just for "nicer code"

Moved to https://invent.kde.org/graphics/gwenview/-/merge_requests/10

Revision Contents
Changeset List

			Path	Packages
M			app/browsemainpage.cpp (3 lines)
M			app/fileopscontextmanageritem.cpp (3 lines)
M			app/folderviewcontextmanageritem.cpp (3 lines)
M			app/kipiinterface.cpp (2 lines)
M			importer/main.cpp (3 lines)
M			lib/contextmanager.cpp (2 lines)
M			lib/document/documentjob.cpp (3 lines)
M			lib/documentview/documentview.cpp (5 lines)
M			lib/documentview/documentviewcontainer.cpp (2 lines)
M			lib/documentview/rasterimageview.cpp (2 lines)
M			lib/documentview/svgviewadapter.cpp (3 lines)
M			lib/documentview/videoviewadapter.cpp (5 lines)
M			lib/mpris2/dbusabstractadaptor.cpp (3 lines)
M			lib/thumbnailprovider/thumbnailprovider.cpp (3 lines)
M			tests/auto/documenttest.cpp (9 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	43322	8b3d0de		Oct 10 2018, 3:58 PM	★	★
Diff 2	43467	2ad1dd4	simplify, leave only invokeMethod() -> QTimer::singleShot() change	Oct 12 2018, 2:55 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
d97de3e2b085	cc3f8d95eca0	2ad1dd48dc26	Alexander Volkov	Get rid of QMetaObject::invokeMethod() with 'const char *member' arg (Show More…)	Oct 10 2018, 3:43 PM

Get rid of QMetaObject::invokeMethod() with 'const char *member' argAbandonedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 43467

app/browsemainpage.cpp

app/fileopscontextmanageritem.cpp

app/folderviewcontextmanageritem.cpp

app/kipiinterface.cpp

importer/main.cpp

lib/contextmanager.cpp

lib/document/documentjob.cpp

lib/documentview/documentview.cpp

lib/documentview/documentviewcontainer.cpp

lib/documentview/rasterimageview.cpp

lib/documentview/svgviewadapter.cpp

lib/documentview/videoviewadapter.cpp

lib/mpris2/dbusabstractadaptor.cpp

lib/thumbnailprovider/thumbnailprovider.cpp

tests/auto/documenttest.cpp

Get rid of QMetaObject::invokeMethod() with 'const char *member' arg
AbandonedPublic
Actions

Revision Contents
Changeset List