use libkeepalive to wakeup daemon
ClosedPublic
Actions

Authored by piggz on Sep 10 2018, 7:26 PM.

Details

Reviewers

nicolasfella
albertvaka

Group Reviewers

KDE Connect

Commits

R224:ee52c8cd03a1: use libkeepalive to wakeup daemon

Summary

Main change is to use libkeepalive to wake up the system to ensure connections stay alive

Other minor changes are:
-Log daemon messages for debugging purposes
-Add way to forece refresh of device list
-Minor spec improvements

The keepalive changes certainly seem to help, not sure if it completely solves the problems
The logging changes are temporary, and I could use them locally, but they only affect sailfish users
Im not sure if the refresh method is correct, but seems to force the daemon to check for devices

Diff Detail

Repository

R224 KDE Connect

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

piggz created this revision.Sep 10 2018, 7:26 PM

Restricted Application added a project: KDE Connect. · View Herald TranscriptSep 10 2018, 7:26 PM

Restricted Application added a subscriber: kdeconnect. · View Herald Transcript

piggz requested review of this revision.Sep 10 2018, 7:26 PM

Harbormaster completed remote builds in B2694: Diff 41362.Sep 10 2018, 7:26 PM

piggz edited the summary of this revision. (Show Details)Sep 10 2018, 7:31 PM

piggz added reviewers: KDE Connect, nicolasfella, albertvaka.

As usual I can't really comment on the SFOS things, but the way the refresh works makes sense. AFAIK we do the same. The keepalive sounds interesting, I would like to give it a more thorough test.

Looks good to me, but I can't test the sailfish part.

I think you should take the role of maintainer for the SFOS parts of kdeconnect :) So, I would say: either merge patches to the SF part directly without review, or add as a reviewer someone more knowledgeable about SFOS than us. I feel like I'm blocking progress on the SF port and can't add much.

core/backends/lan/lanlinkprovider.cpp
356	Don't push those uncomments, they will print a lot of spam.

This revision is now accepted and ready to land.Sep 22 2018, 12:09 PM

Dont use clipboard plugin on sailfish as it uses wayland

Harbormaster completed remote builds in B4130: Diff 44079.Oct 22 2018, 5:12 PM

Closed by commit R224:ee52c8cd03a1: use libkeepalive to wakeup daemon (authored by piggz). · Explain WhyOct 23 2018, 7:31 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			core/backends/lan/lanlinkprovider.cpp (4 lines)
M			plugins/CMakeLists.txt (2 lines)
M			sfos/CMakeLists.txt (5 lines)
M			sfos/qml/pages/FindDevices.qml (9 lines)
M			sfos/rpm/kdeconnect-sfos.spec (6 lines)
M			sfos/sailfishdaemon.cpp (51 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	41362	064b07c		Sep 10 2018, 7:26 PM	★	★
Diff 2	44079	1e9a1f9	- Dont use clipboard plugin on sailfish as it uses wayland	Oct 22 2018, 5:12 PM	★	★
Diff 3	44092	a98533b	R224:ee52c8cd03a13b31e58b1fc5bddb9cdbd4ccd7dc	Oct 23 2018, 7:30 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
197f6a35a82b	76087bcd6b93	57be9c905e47	Adam Pigg	Dont use clipboard plugin on sailfish as it uses wayland	Oct 22 2018, 5:12 PM
57be9c905e47	738ec18530fb	700a8761c64f	Adam Pigg	use libkeepalive to wakeup daemon (Show More…)	Sep 10 2018, 7:22 PM
700a8761c64f	f6fb9434af46	da1a0a60a69e	Adam Pigg	Add way to forece refresh of device list	Sep 10 2018, 7:19 PM
da1a0a60a69e	0e2567cde61d	c7eba4015a3b	Adam Pigg	Cleanup message handler	Sep 10 2018, 7:11 PM
c7eba4015a3b	8ad5f466ab46	1e9a1f93ed10	Adam Pigg	use libkeepalive to wakeup daemon	Sep 4 2018, 9:35 PM