Give the "invalid directory name" dialog a cancel button
ClosedPublic

Authored by ngraham on Aug 6 2018, 10:59 PM.

Details

Summary

Adds a cancel button to the "Invalid Directory Name" dialog.

Test Plan

  • Try to create a new folder named . or ..
  • In the resulting dialog, click Enter a Different Name -> you are prompted to choose a new name
  • Enter . or .. again
  • In the resulting dialog, click Cancel -> dialog disappears
  • Do the above, but enter a valid name when prompted -> the folder is created using the valid name

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Aug 6 2018, 10:59 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptAug 6 2018, 10:59 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ngraham requested review of this revision.Aug 6 2018, 10:59 PM
ngraham edited the test plan for this revision. (Show Details)Aug 6 2018, 11:11 PM
ngraham edited the test plan for this revision. (Show Details)
ngraham updated this revision to Diff 39275.Aug 7 2018, 9:18 PM

Rebase on latest master

dfaure accepted this revision.Aug 8 2018, 8:22 AM
This revision is now accepted and ready to land.Aug 8 2018, 8:22 AM
This revision was automatically updated to reflect the committed changes.