Differential D10217

Choose source with a combobox, but only on the desktop view
AbandonedPublic
Actions

Authored by ngraham on Jan 31 2018, 10:07 PM.

Details

Reviewers
apol
Group Reviewers
Discover Software Store
VDG
Summary

Here I am again, hawking my combobox... :)

This patch uses a combobox to select the source, but only for the desktop view. People are always complaining that Discover's desktop view doesn't feel like a desktop app, and exclusively using a desktop-metaphor UI element here would help the situation, I believe.

On mobile, the UI is unchanged, and we show the overlay, which has always felt more mobile-like anyway. It's more at home on that view.

When there is only a single source, we show a simple label for both desktop and mobile.

Test Plan

Tested in KDE Neon. Source switching still works for all views and apps.

Desktop view, single source:

Desktop view, multiple sources:

Desktop view, source chooser in action:

Mobile view, single source:

Mobile view, multiple sources:

Mobile view, source chooser in action:

Diff Detail

Repository
R134 Discover Software Store
Branch
combobox-on-desktop
Lint
No Linters Available
Unit
No Unit Test Coverage
ngraham created this revision.Jan 31 2018, 10:07 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 31 2018, 10:07 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Jan 31 2018, 10:07 PM
ngraham edited the summary of this revision. (Show Details)Jan 31 2018, 10:09 PM
ngraham edited the test plan for this revision. (Show Details)
rkflx added a subscriber: rkflx.EditedJan 31 2018, 11:31 PM

FWIW, I nearly commented on one of your early blog posts. I wanted to suggest a combobox to:

  • indicate the possibility to make a selection (which a link clearly fails at)
  • solve the issue of having to move the mouse to a completely different location (usability problem)

You got the (obvious) combobox idea yourself meanwhile, but at least have my +1 here ;)

If the combobox sticks out too much visually, try the QML equivalent of setFrame(false) (did not test yet, though).

ngraham abandoned this revision.Feb 1 2018, 2:48 AM

Discussed it internally, not popular.

dcahal added a subscriber: dcahal.Feb 1 2018, 3:04 AM

Are there problems with implementation? I don't understand why this concept would not be considered an improvement to the way source selection is handled.

ngraham added a comment.Feb 1 2018, 6:13 PM

We were not able to achieve consensus, I'm afraid. If you'd like to be involved in Discover's design, please let me know and I'll invite you to the Discover-Design Telegram room, where we discuss these things.

Revision Contents
Changeset List

PathPackages
Mdiscover/qml/ApplicationPage.qml (39 lines)

Diff 26294

View Options

discover/qml/ApplicationPage.qml

Loading...